Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#414 Fix Location header behind HTTPS proxy #415

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Issue#414 Fix Location header behind HTTPS proxy #415

wants to merge 1 commit into from

Conversation

psmirnov-dermview
Copy link

  • Server.php behind HTTPS reverse proxy
  • Stop assuming the FQDN in Location header in responses
  • Rely upon ApiPath configuration instead
  • Responds with relative URLs by default

@ankitpokhrel
Copy link
Owner

@psmirnov-dermview Thank you for working on this. Could you please fix the tests?

jfstenuit
jfstenuit reviewed Apr 13, 2023
View reviewed changes
Copy link

@jfstenuit jfstenuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the issue and I can confirm this patch addresses it in my set-up.

@psmirnov-dermview @ankitpokhrel
Issue#414 Fix Location header behind HTTPS proxy
498ef04 
- Server.php behind HTTPS reverse proxy
- Stop assuming the FQDN in Location header in responses
- Rely upon ApiPath configuration instead
- Responds with relative URLs by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfstenuit jfstenuit jfstenuit left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psmirnov-dermview @ankitpokhrel @jfstenuit